Discussion:
[Bug backtrace/23203] bt full moves selected frame to main
cvs-commit at gcc dot gnu.org
2018-05-24 17:02:36 UTC
Permalink
https://sourceware.org/bugzilla/show_bug.cgi?id=23203

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Burgess <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=45f25d6c83c31a48a01ef8293bb3978f5e58e653

commit 45f25d6c83c31a48a01ef8293bb3978f5e58e653
Author: Andrew Burgess <***@embecosm.com>
Date: Fri May 18 17:45:16 2018 +0100

gdb: Restore selected frame in print_frame_local_vars

PR gdb/23203 reports 'bt full' causing the currently selected frame to
change, this issue is fixed in this commit.

Add a new class scoped_restore_selected_frame that saves and restores
the selected frame. Make use of this in print_frame_local_vars to
restore the selected frame on exit.

gdb/ChangeLog:

PR gdb/23203
* frame.c
(scoped_restore_selected_frame::scoped_restore_selected_frame):
Define.
(scoped_restore_selected_frame::~scoped_restore_selected_frame):
Define.
* frame.h (class scoped_restore_selected_frame): New class.
* stack.c (print_frame_local_vars): Remove catching and rethrowing
of any exception, use scoped_restore_selected_frame to restore the
frame instead.

gdb/testsuite/ChangeLog:

PR gdb/23203
* gdb.base/bt-selected-frame.c: New file.
* gdb.base/bt-selected-frame.exp: New file.
* lib/gdb.exp (get_current_frame_number): New function.
--
You are receiving this mail because:
You are on the CC list for the bug.
andrew.burgess at embecosm dot com
2018-05-24 21:44:53 UTC
Permalink
https://sourceware.org/bugzilla/show_bug.cgi?id=23203

--- Comment #4 from Andrew Burgess <andrew.burgess at embecosm dot com> ---
I'm unable to change the status of this bug, but after commit 45f25d6c83c31a48
I believe this issue is now resolved.
--
You are receiving this mail because:
You are on the CC list for the bug.
simon.marchi at ericsson dot com
2018-05-25 02:36:28 UTC
Permalink
https://sourceware.org/bugzilla/show_bug.cgi?id=23203

Simon Marchi <simon.marchi at ericsson dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |simon.marchi at ericsson dot com
Resolution|--- |FIXED

--- Comment #5 from Simon Marchi <simon.marchi at ericsson dot com> ---
Hmm strange.
--
You are receiving this mail because:
You are on the CC list for the bug.
palves at redhat dot com
2018-05-25 10:05:13 UTC
Permalink
https://sourceware.org/bugzilla/show_bug.cgi?id=23203

Pedro Alves <palves at redhat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |palves at redhat dot com

--- Comment #6 from Pedro Alves <palves at redhat dot com> ---
(In reply to Andrew Burgess from comment #4)
Post by andrew.burgess at embecosm dot com
I'm unable to change the status of this bug, but after commit
45f25d6c83c31a48 I believe this issue is now resolved.
Your account did not have editbugs privileges. Fixed now, and also did the
same to other embecosm.com accounts (Graham, Jeremy, Simon).
--
You are receiving this mail because:
You are on the CC list for the bug.
Loading...