[Bug tui/23408] New: [aarch64] tui rename cpsr to pstate

[wughetta at princeton dot edu]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

Bug ID: 23408
Summary: [aarch64] tui rename cpsr to pstate
Product: gdb
Version: HEAD
Status: UNCONFIRMED
Severity: enhancement
Priority: P2
Component: tui
Assignee: unassigned at sourceware dot org
Reporter: wughetta at princeton dot edu
Target Milestone: ---

In the gdb tui register layout for aarch64, the flags register is referred to
as "cpsr". It should be called "pstate" according to the ARMv8 Reference Manual
sections A1.3.1 and D1.7

Would changing the display name in gdb/aarch64-tdep.c or refactoring references
to AARCH64_CPSR_REGNUM make sense?

[wughetta at princeton dot edu]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

William Ughetta <wughetta at princeton dot edu> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |wughetta at princeton dot edu

--- Comment #1 from William Ughetta <wughetta at princeton dot edu> ---
Created attachment 11125
--> https://sourceware.org/bugzilla/attachment.cgi?id=11125&action=edit
[Patch] AArch64 Rename CPSR to PSTATE

A less extensive patch would be to just change the display name to PSTATE in
gdb/aarch64-tdep.c

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
Thanks for the patch.
gdb patches should normally be sent to the mailing list,
see the contribution instructions:
https://sourceware.org/gdb/wiki/ContributionChecklist

[wughetta at princeton dot edu]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

--- Comment #3 from William Ughetta <wughetta at princeton dot edu> ---
Thank you, I will send out an updated patch to the mailing list including the
ChangeLog. I am in the process of running the testsuite. In case it is of
insterest, I used ```grep -r -i --include *aarch64* cpsr``` to find all cpsr
references in aarch64 files.

One difference I am looking into is a "warning: Architecture rejected
target-supplied description" in the gdb prompt after running "(gdb) target
remote :1234" during a manual test.

[wughetta at princeton dot edu]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

--- Comment #4 from William Ughetta <wughetta at princeton dot edu> ---
Created attachment 11142
--> https://sourceware.org/bugzilla/attachment.cgi?id=11142&action=edit
testsuite-2018-07-17.diff

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|tui |tdep

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
I think this is more of a tdep bug than a TUI bug.

[wughetta at princeton dot edu]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

--- Comment #6 from William Ughetta <wughetta at princeton dot edu> ---
Do you have any input/thoughts on the approach in the submitted patch 28447
(https://patchwork.sourceware.org/patch/28447/) to change all references to
cpsr to pstate in aarch64 files?

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23408

--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to William Ughetta from comment #6)

Post by wughetta at princeton dot edu
Do you have any input/thoughts on the approach in the submitted patch 28447
(https://patchwork.sourceware.org/patch/28447/) to change all references to
cpsr to pstate in aarch64 files?

I'm afraid I don't -- I don't really know anything about aarch64.
The best thing to do is send a follow-up "ping" email to gdb-patches.
You may have to do this weekly (sorry) until someone responds.