[Bug build/18632] New: Don't build readline/libreadline.a, when --with-system-readline is supplied

[dilyan.palauzov at aegee dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

Bug ID: 18632
Summary: Don't build readline/libreadline.a, when
--with-system-readline is supplied
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: build
Assignee: unassigned at sourceware dot org
Reporter: dilyan.palauzov at aegee dot org
Target Milestone: ---

The bundled libreadline is always built, even if the system is ./configure'd
--with-system-readline and the build libreadline.a is not used.

Proposed patch:

Fix ./configure.ac not to proceed readline/, when --with-system-readline is
provided

diff --git a/configure.ac b/configure.ac
index 159f968..adf6dfb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
noconfigdirs="$noconfigdirs zlib"
fi

+# Don't compile the bundled readline/libreadline.a if --with-system-readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+ noconfigdirs="$noconfigdirs readline"
+fi
+
# some tools are so dependent upon X11 that if we're not building with X,
# it's not even worth trying to configure, much less build, that tool.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
This seems good, but since the top-level configury is canonically maintained
in gcc, the patch should go to gcc-patches.

[dilyan.palauzov at aegee dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

--- Comment #2 from dilyan.palauzov at aegee dot org <dilyan.palauzov at aegee dot org> ---
GCC do not use readline, why shall it integrate this snippet?

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---

Post by dilyan.palauzov at aegee dot org
GCC do not use readline, why shall it integrate this snippet?

The top-level configure+Makefile code is maintained in the
gcc repository, then sync'd over to binutils-gdb.
So even though gcc doesn't use this, it has this code in it.

[dilyan.palauzov at aegee dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

--- Comment #4 from dilyan.palauzov at aegee dot org <dilyan.palauzov at aegee dot org> ---
I submitted https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87741 .