[Bug gdb/19768] New: aligned raw disassemble dump

[daniel.gutson at tallertechnologies dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

Bug ID: 19768
Summary: aligned raw disassemble dump
Product: gdb
Version: unknown
Status: NEW
Severity: enhancement
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: daniel.gutson at tallertechnologies dot com
Target Milestone: ---

This issue is to continue the initial patch and discussion here:
https://sourceware.org/ml/gdb-patches/2014-04/msg00226.html

Leonardo Boquillon will send next the next patch containing the suggested
changes.

[daniel.gutson at tallertechnologies dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

Daniel Gutson <daniel.gutson at tallertechnologies dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@tallertechnol
| |ogies.com

[leonardo.boquillon at tallertechnologies dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

Leonardo Boquillon <leonardo.boquillon at tallertechnologies dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@tallerte
| |chnologies.com

--- Comment #1 from Leonardo Boquillon <leonardo.boquillon at tallertechnologies dot com> ---
Created attachment 9066
--> https://sourceware.org/bugzilla/attachment.cgi?id=9066&action=edit
Patch to solve the non-aligned raw disassemble dump

[leonardo.boquillon at tallertechnologies dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

Leonardo Boquillon <leonardo.boquillon at tallertechnologies dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |dje at google dot com,
| |qiyao at gcc dot gnu.org

--- Comment #2 from Leonardo Boquillon <leonardo.boquillon at tallertechnologies dot com> ---
Pinging this patch. Is it ok to commit? I have a company-wide copyright access,
and a coworker of mine is a write-after-approval maintainer.

[leonardo.boquillon at tallertechnologies dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

Leonardo Boquillon <leonardo.boquillon at tallertechnologies dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |***@tallerte
| |chnologies.com

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

--- Comment #3 from dje at google dot com ---
Filing for my own reference sake.

I believe we've agreed on a two pass solution.
ref: https://sourceware.org/ml/gdb-patches/2014-04/msg00427.html

[leonardo.boquillon at tallertechnologies dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

--- Comment #4 from Leonardo Boquillon <leonardo.boquillon at tallertechnologies dot com> ---
(In reply to dje from comment #3)

Post by dje at google dot com
Filing for my own reference sake.
I believe we've agreed on a two pass solution.
ref: https://sourceware.org/ml/gdb-patches/2014-04/msg00427.html

Hi Doug,

The patch I've attached performs the two passes: the first is at
get_insn_set_longest_opcode at line 136 in the patch, and the second is the
while loop that follows. I spoke with Daniel Gutson and we both agreed it
should work like this. Please let us know if we misunderstood what was
requested.

[leonardo.boquillon at tallertechnologies dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

--- Comment #5 from Leonardo Boquillon <leonardo.boquillon at tallertechnologies dot com> ---
I'm pinging this patch again. Can anyone check it out? Is it ok to commit? I
have a company-wide copyright access, and a coworker of mine is a
write-after-approval maintainer.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19768

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
I'm sorry about the lack of replies.
The gdb project doesn't normally review patches in bugzilla
nor, apparently, read bugzilla at all :-}.

Please follow the contribution instructions instead:
https://sourceware.org/gdb/wiki/ContributionChecklist