[Bug breakpoints/20001] New: src/gdb/breakpoint.c:3092: redundant test ?

[dcb314 at hotmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20001

Bug ID: 20001
Summary: src/gdb/breakpoint.c:3092: redundant test ?
Product: gdb
Version: HEAD
Status: NEW
Severity: minor
Priority: P2
Component: breakpoints
Assignee: unassigned at sourceware dot org
Reporter: dcb314 at hotmail dot com
Target Milestone: ---

src/gdb/breakpoint.c:3092]: (style) Redundant condition: bl.inserted.
'!bl.inserted || (bl.inserted && !bl.needs_update)' is equivalent to
'!bl.inserted || !bl.needs_update'

Source code is

if (!bl->inserted || (bl->inserted && !bl->needs_update))

[ysimhony at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20001

ysimhony at gmail dot com changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |ysimhony at gmail dot com

--- Comment #1 from ysimhony at gmail dot com ---
Hi,

This issue can be closed.

I merged a fix to the issue with Tom's assistacne.

Thanks,
Yacov

[sergiodj at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20001

Sergio Durigan Junior <sergiodj at redhat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
CC| |sergiodj at redhat dot com

--- Comment #2 from Sergio Durigan Junior <sergiodj at redhat dot com> ---
(In reply to ysimhony from comment #1)

Post by ysimhony at gmail dot com
Hi,
This issue can be closed.
I merged a fix to the issue with Tom's assistacne.
Thanks,
Yacov

Could you post the commit hash here, just for documentation purposes? Thanks.

[sergiodj at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20001

Sergio Durigan Junior <sergiodj at redhat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution|--- |FIXED

--- Comment #3 from Sergio Durigan Junior <sergiodj at redhat dot com> ---
Nevermind, I found it:

commit 4daf19021fef36767e70845608a8a2c3b4d72f99
Author: Yacov Simhony <***@gmail.com>
Date: Fri Sep 21 07:53:51 2018 -0600

Remove redundant test in update_inserted_breakpoint_locations

Remove a redundant test in update_inserted_breakpoint_locations.

gdb/ChangeLog
2018-09-21 Yacov Simhony <***@gmail.com>

* breakpoint.c (update_inserted_breakpoint_locations): Remove
redundant condition.


Closing the bug, then.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20001

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
Target Milestone|--- |8.3