[Bug python/22731] New: allow assigning to breakpoint commands

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22731

Bug ID: 22731
Summary: allow assigning to breakpoint commands
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: python
Assignee: unassigned at sourceware dot org
Reporter: tromey at sourceware dot org
Target Milestone: ---

See
https://stackoverflow.com/questions/48312903/how-to-set-or-modify-breakpoint-commands-in-a-gdb-python-script

It would be nice to be able to assign to a breakpoint's "commands" field from
Python.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22731

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I have a patch for this.

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22731

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a913fffbdee21fdd50e8de0596358be425775678

commit a913fffbdee21fdd50e8de0596358be425775678
Author: Tom Tromey <***@tromey.com>
Date: Wed Apr 18 17:37:56 2018 -0600

Allow breakpoint commands to be set from Python

This changes the Python API so that breakpoint commands can be set by
writing to the "commands" attribute.

ChangeLog
2018-05-04 Tom Tromey <***@tromey.com>

PR python/22731:
* NEWS: Mention that breakpoint commands are writable.
* python/py-breakpoint.c (bppy_set_commands): New function.
(breakpoint_object_getset) <"commands">: Use it.

doc/ChangeLog
2018-05-04 Tom Tromey <***@tromey.com>

PR python/22731:
* python.texi (Breakpoints In Python): Mention that "commands" is
writable.

testsuite/ChangeLog
2018-05-04 Tom Tromey <***@tromey.com>

PR python/22731:
* gdb.python/py-breakpoint.exp: Test setting breakpoint commands.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22731

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |8.2

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

[edaskel at att dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=22731

Jeff Trull <edaskel at att dot net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |edaskel at att dot net

--- Comment #4 from Jeff Trull <edaskel at att dot net> ---
This doesn't seem to have made it into the recent 8.1.1 release, unless I'm
mistaken.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22731

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Jeff Trull from comment #4)

Post by edaskel at att dot net
This doesn't seem to have made it into the recent 8.1.1 release, unless I'm
mistaken.

Correct, it will show up in 8.2, which should be coming out soonish.
Normally in gdb, new features aren't backported to an existing release
branch - only bug fixes are.