[Bug gdb/22950] New: SYS_uuidsys undefined on Solaris

[grobian at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22950

Bug ID: 22950
Summary: SYS_uuidsys undefined on Solaris
Product: gdb
Version: 8.1
Status: NEW
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: grobian at gentoo dot org
Target Milestone: ---

Created attachment 10887
--> https://sourceware.org/bugzilla/attachment.cgi?id=10887&action=edit
Solaris SYS_uuidsys patch

confirmed this problem on Solaris 10 Sparc and OpenIndiana x64:

x86_64-pc-solaris2.11-g++ -x c++ -O2 -pipe -I. -I. -I./common -I./config
-DLOCALEDIR="\"/gentoo/prefix64/usr/share/locale\"" -DHAVE_CONFIG_H
-I./../include/opcode -I./../opcodes/.. -I../bfd -I./../bfd -I./../include
-I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import
-DTUI=1 -I/gentoo/prefix64/usr/include
-I/gentoo/prefix64/usr/include/python3.5
-I/gentoo/prefix64/usr/include/python3.5 -Wall -Wpointer-arith -Wno-unused
-Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body
-Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare
-Wno-narrowing -Wno-error=maybe-uninitialized -Wno-unknown-pragmas
-Wno-deprecated-declarations -c -o amd64-nat.o -MT amd64-nat.o -MMD -MP -MF
./.deps/amd64-nat.Tpo amd64-nat.c
proc-events.c: In function ‘void init_syscall_table()’:
proc-events.c:496:17: error: ‘SYS_uuidsys’ was not declared in this scope
syscall_table[SYS_uuidsys] = "uuidsys";
^~~~~~~~~~~
make[2]: *** [Makefile:1620: proc-events.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory
'/gentoo/prefix64/var/tmp/portage/sys-devel/gdb-8.1/work/gdb-8.1/gdb'
make[1]: *** [Makefile:8156: all-gdb] Error 2
make[1]: Leaving directory
'/gentoo/prefix64/var/tmp/portage/sys-devel/gdb-8.1/work/gdb-8.1'
make: *** [Makefile:849: all] Error 2

sys/syscall.h doesn't define SYS_uuidsys. Please add the attached patch to the
patchset that makes the usage of this symbol conditional.

Attached patch simply guards the usage of SYS_uuidsys.

[simon.marchi at ericsson dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22950

Simon Marchi <simon.marchi at ericsson dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |simon.marchi at ericsson dot com

--- Comment #1 from Simon Marchi <simon.marchi at ericsson dot com> ---
Hi Fabian,

Can you please submit the patch to gdb-***@sourceware.org, following the
guidelines here?

https://sourceware.org/gdb/wiki/ContributionChecklist

Thanks,

Simon

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22950

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e28b63a989caffa4a6fba1aaf0d8992b37d13da8

commit e28b63a989caffa4a6fba1aaf0d8992b37d13da8
Author: Fabian Groffen <***@gentoo.org>
Date: Sun Apr 29 12:04:54 2018 -0400

proc-events.c: fix compilation on Solaris

This patch adds a guard around the usage of SYS_uuidsys, which is
not available on (at least) Solaris 10 and OpenIndiana.

gdb/ChangeLog:

PR gdb/22950
* proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
with #ifdef.

[simon.marchi at ericsson dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22950

Simon Marchi <simon.marchi at ericsson dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #3 from Simon Marchi <simon.marchi at ericsson dot com> ---
Thanks for the patch, it's now pushed.