[Bug tui/18388] New: "tabset" command should be replaced

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18388

Bug ID: 18388
Summary: "tabset" command should be replaced
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: tui
Assignee: unassigned at sourceware dot org
Reporter: tromey at sourceware dot org
Target Milestone: ---

The TUI provides a "tabset" command to set the tab width.
I think this should be deprecated and replaced with something
like "set tui tab-width".

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18388

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18388

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7806cea72329a354c36ed8b2177d03f9d5e2673f

commit 7806cea72329a354c36ed8b2177d03f9d5e2673f
Author: Tom Tromey <***@tromey.com>
Date: Sun Sep 2 19:41:41 2018 -0600

Deprecate and replace the "tabset" command

The "tabset" command sets the tab width as used by the TUI for source
and disassembly display.

This command has long seemed to be misnamed to me. It is more in
keeping with gdb design to call it "set tui tab-width". Also, making
this change allows for the corresponding "show" command to work.

gdb/ChangeLog
2018-10-19 Tom Tromey <***@tromey.com>

PR tui/18388:
* NEWS: Mention tabset deprecation.
* tui/tui-win.c (tui_tab_width, internal_tab_width): New globals.
(update_tab_width): New function.
(tui_set_tab_width, tui_show_tab_width): New functions.
(tui_set_tab_width_command): Use update_tab_width.
(_initialize_tui_win): Move to end of file. Deprecate "tabset".
Add new "set tui tab-width" command.
* tui/tui-source.c (tui_set_source_content): Update.
* tui/tui-disasm.c (tui_set_disassem_content): Update.
* tui/tui-data.h (tui_default_tab_len, tui_set_default_tab_len):
Don't declare.
(tui_tab_width): Declare.
* tui/tui-data.c (default_tab_len, tui_default_tab_len)
(tui_set_default_tab_len): Remove.

gdb/doc/ChangeLog
2018-10-19 Tom Tromey <***@tromey.com>

PR tui/18388:
* gdb.texinfo (TUI Commands): Remove tabset documentation.
(TUI Configuration): Document "set tui tab-width".

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18388

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |8.3

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.