[Bug build/23814] New: error: conflicting return type specified for ‘virtual bool ia64_linux_nat_target::have_steppable_watchpoint()’

[[e-mail]]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Bug ID: 23814
Summary: error: conflicting return type specified for ‘virtual
bool
ia64_linux_nat_target::have_steppable_watchpoint()’
Product: gdb
Version: 8.2
Status: NEW
Severity: normal
Priority: P2
Component: build
Assignee: unassigned at sourceware dot org
Reporter: ***@linux-m68k.org
Target Milestone: ---
Host: ia64-*-*

../../gdb/ia64-linux-nat.c:73:8: error: conflicting return type specified for
‘virtual bool ia64_linux_nat_target::have_steppable_watchpoint()’
bool have_steppable_watchpoint () { return 1; }
^
In file included from ../../gdb/inferior.h:41:0,
from ../../gdb/ia64-linux-nat.c:22:
../../gdb/target.h:557:17: error: overriding ‘virtual int
target_ops::have_steppable_watchpoint()’
virtual int have_steppable_watchpoint ()
^
../../gdb/ia64-linux-nat.c:73:8: warning: ‘virtual bool
ia64_linux_nat_target::have_steppable_watchpoint()’ can be marked override
[-Wsuggest-override]
bool have_steppable_watchpoint () { return 1; }
^
CXX infcmd.o
../../gdb/ia64-linux-nat.c:676:1: warning: ‘void
ia64_linux_new_thread(lwp_info*)’ defined but not used [-Wunused-function]
ia64_linux_new_thread (struct lwp_info *lp)
^
../../gdb/ia64-linux-nat.c:723:1: warning: ‘int
ia64_linux_can_use_hw_breakpoint(target_ops*, bptype, int, int)’ defined but
not used [-Wunused-function]
ia64_linux_can_use_hw_breakpoint (struct target_ops *self,
^
make[2]: *** [ia64-linux-nat.o] Error 1

[[e-mail]]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Andreas Schwab <***@linux-m68k.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |palves at redhat dot com

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 11393
--> https://sourceware.org/bugzilla/attachment.cgi?id=11393&action=edit
patch attempt

I don't have access to an IA-64.
Please try this patch.

[[e-mail]]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

--- Comment #2 from Andreas Schwab <***@linux-m68k.org> ---
../../gdb/ia64-linux-nat.c:723:1: error: prototype for ‘int
ia64_linux_nat_target::can_use_hw_breakpoint(target_ops*, bptype, int, int)’
does not match any in class ‘ia64_linux_nat_target’
ia64_linux_nat_target::can_use_hw_breakpoint (struct target_ops *self,
^
../../gdb/ia64-linux-nat.c:75:7: error: candidate is: virtual int
ia64_linux_nat_target::can_use_hw_breakpoint(bptype, int, int)
int can_use_hw_breakpoint (enum bptype, int, int) override;
^
../../gdb/ia64-linux-nat.c:676:1: warning: ‘void
ia64_linux_new_thread(lwp_info*)’ defined but not used [-Wunused-function]
ia64_linux_new_thread (struct lwp_info *lp)
^

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #11393|0 |1
is obsolete| |

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 11394
--> https://sourceware.org/bugzilla/attachment.cgi?id=11394&action=edit
try #2

Try #2.

[[e-mail]]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

--- Comment #4 from Andreas Schwab <***@linux-m68k.org> ---
../../gdb/ia64-linux-nat.c:676:55: error: no ‘void
ia64_linux_nat_target::new_thread(lwp_info*)’ member function declared in class
‘ia64_linux_nat_target’
ia64_linux_nat_target::new_thread (struct lwp_info *lp)
^
../../gdb/ia64-linux-nat.c:724:34: error: cannot declare member function
‘virtual int ia64_linux_nat_target::can_use_hw_breakpoint(bptype, int, int)’ to
have static linkage [-fpermissive]
int cnt, int othertype)
^

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #11394|0 |1
is obsolete| |

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 11395
--> https://sourceware.org/bugzilla/attachment.cgi?id=11395&action=edit
try #3

Try #3.

[[e-mail]]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

--- Comment #6 from Andreas Schwab <***@linux-m68k.org> ---
../../gdb/ia64-linux-nat.c:676:55: error: no ‘void
ia64_linux_nat_target::new_thread(lwp_info*)’ member function declared in class
‘ia64_linux_nat_target’
ia64_linux_nat_target::new_thread (struct lwp_info *lp)
^
../../gdb/ia64-linux-nat.c:724:34: error: cannot declare member function
‘virtual int ia64_linux_nat_target::can_use_hw_breakpoint(bptype, int, int)’ to
have static linkage [-fpermissive]
int cnt, int othertype)
^

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #11395|0 |1
is obsolete| |

--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 11397
--> https://sourceware.org/bugzilla/attachment.cgi?id=11397&action=edit
try #4

Try #4.

[[e-mail]]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

--- Comment #8 from Andreas Schwab <***@linux-m68k.org> ---
ia64-linux-nat.o:(.data.rel.ro._ZTV21ia64_linux_nat_target[_ZTV21ia64_linux_nat_target]+0x640):
undefined reference to `ia64_linux_nat_target::read_description()'

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #11397|0 |1
is obsolete| |

--- Comment #9 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 11399
--> https://sourceware.org/bugzilla/attachment.cgi?id=11399&action=edit
try #5

Try #5. It seems the read_description addition was spurious
back when the c++-ificatino was done.

[[e-mail]]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

--- Comment #10 from Andreas Schwab <***@linux-m68k.org> ---
Success!

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c2a6c5da37c0135acdb859ca819870980db69b77

commit c2a6c5da37c0135acdb859ca819870980db69b77
Author: Tom Tromey <***@tromey.com>
Date: Wed Nov 14 09:29:51 2018 -0700

Fix ia64-linux-nat.c

PR build/23814 points out that ia64-linux-nat.c will not compile any
more. This patch fixes the problem. Thanks to Andreas Schwab for
trying the patch.

gdb/ChangeLog
2018-11-18 Tom Tromey <***@tromey.com>

PR build/23814:
* target-delegates.c: Rebuild.
* ia64-linux-nat.c (class ia64_linux_nat_target)
<have_steppable_watchpoint>: Use override. Return true, not 1.
(ia64_linux_nat_target::can_use_hw_breakpoint): Rename. Remove
"self" argument.
(ia64_linux_nat_target::low_new_thread): Rename.
(class ia64_linux_nat_target) <read_description>: Don't declare.
* target.h (struct target_ops) <have_steppable_watchpoint>: Return
bool.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23814

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |8.3

--- Comment #12 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.