[Bug gdb/23095] New: Test case gdb.base/break-probes.exp fails on FreeBSD

[rajendra.sy at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23095

Bug ID: 23095
Summary: Test case gdb.base/break-probes.exp fails on FreeBSD
Product: gdb
Version: HEAD
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: rajendra.sy at gmail dot com
Target Milestone: ---

Created attachment 10968
--> https://sourceware.org/bugzilla/attachment.cgi?id=10968&action=edit
Patch to fix test case on FreeBSD

There are two problems in this test case
1. linking -dl lib which fails on FreeBSD platform
2. the backtrace from ld-elf shows r_debug_state() instead of _dl_debug_state

Log:
UNTESTED: gdb.base/break-probes.exp: failed to prepare

Attached patch fixes both these problems.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23095

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Thanks for the patch. Please follow the contribution instructions
to have it reviewed:

https://sourceware.org/gdb/wiki/ContributionChecklist

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23095

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=db86b02b3ac8426f3fc0754f48f3645235cc2ae6

commit db86b02b3ac8426f3fc0754f48f3645235cc2ae6
Author: Rajendra SY <***@gmail.com>
Date: Sun Apr 22 18:19:26 2018 -0400

Fixed test case to compile & run on FreeBSD

Problems:
1. linking -dl lib on FreeBSD platform
2. backtrace from ld-elf shows r_debug_state() instead of _dl_debug_state()

Cause:
1. There is no dl library on FreeBSD platform test has to ignore linking
"-ldl"
2. The stop due to a shared library event shows backtrace frame #0
function as r_debug_state()

gdb/ChangeLog:

PR gdb/23095
* gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
prepare_for_testing. Set normal_bp to r_debug_state if target
is bsd.

[simon.marchi at ericsson dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23095

Simon Marchi <simon.marchi at ericsson dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |simon.marchi at ericsson dot com
Resolution|--- |FIXED

--- Comment #3 from Simon Marchi <simon.marchi at ericsson dot com> ---
Pushed, thanks for the patch!