[Bug gdb/16454] New: target_shortname abuse

[tromey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16454

Bug ID: 16454
Summary: target_shortname abuse
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: tromey at redhat dot com

Many of the uses of target_shortname in the tree
are actually abuses. E.g.:

if (strcmp (target_shortname, "sim") == 0)
return bfin_sim_breakpoint;
else
return bfin_breakpoint;

In addition to the hack of a name-based decision,
this assumes that the "sim" target will be the topmost
on the target stack.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16454

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
There seem to be exactly 2 such cases - one checking for sim
and one checking for remote.