[Bug gdb/11750] "define" does not properly recognize a nested define

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=11750

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2018-04-18
CC| |tromey at sourceware dot org
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org
Ever confirmed|0 |1

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I have a patch for this.

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=11750

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7a2c85f25977ff9b11728ba85b1417538e22c246

commit 7a2c85f25977ff9b11728ba85b1417538e22c246
Author: Tom Tromey <***@tromey.com>
Date: Wed Apr 18 16:10:59 2018 -0600

Allow defining a user command inside a user command

PR gdb/11750 concerns defining a command inside a user commnad, like:

define outer
define inner
echo hi\n
end
end

This patch adds this capability to gdb.

ChangeLog
2018-05-04 Tom Tromey <***@tromey.com>

PR gdb/11750:
* cli/cli-script.h (enum command_control_type) <define_control>:
New constant.
* cli/cli-script.c (multi_line_command_p): Handle define_control.
(build_command_line, execute_control_command_1)
(process_next_line): Likewise.
(do_define_command): New function, extracted from define_command.
(define_command): Use it.

testsuite/ChangeLog
2018-05-04 Tom Tromey <***@tromey.com>

PR gdb/11750:
* gdb.base/define.exp: Test defining a user command inside a user
command.
* gdb.base/commands.exp (define_if_without_arg_test): Test "define".

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=11750

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|7.1 |8.2

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.