[Bug gdb/15438] New: dangling cleanup in keep_going

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15438

Bug #: 15438
Summary: dangling cleanup in keep_going
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: gdb
AssignedTo: ***@sourceware.org
ReportedBy: ***@redhat.com
Classification: Unclassified


infrun.c:keep_going has one return that does not deal with cleanups:

if (e.reason < 0)
{
exception_print (gdb_stderr, e);
stop_stepping (ecs);
return;
}

It isn't clear to me whether this should do_cleanups or discard_cleanups.

[palves at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15438

Pedro Alves <palves at redhat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |palves at redhat dot com

--- Comment #1 from Pedro Alves <palves at redhat dot com> 2013-05-07 18:00:41 UTC ---
discard_cleanups. The caller of handle_inferior_event will notice
stop_stepping was called (checks for !ecs->wait_some_more), and ultimately
normal_stop will end up being called.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15438

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |tromey at sourceware dot org
Resolution|--- |FIXED

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
keep_going doesn't have cleanups any more