[Bug varobj/23378] New: [8.1 -> 8.2 regression] gdb.mi/mi-var-cmd.exp, with gdbserver

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23378

Bug ID: 23378
Summary: [8.1 -> 8.2 regression] gdb.mi/mi-var-cmd.exp, with
gdbserver
Product: gdb
Version: unknown
Status: NEW
Severity: normal
Priority: P2
Component: varobj
Assignee: unassigned at sourceware dot org
Reporter: palves at redhat dot com
Target Milestone: ---

On Fedora 27, with --target_board=native-gdbserver, comparing 8.1 vs 8.2/master
test results, I see this regression:

-PASS: gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: in scope now
+FAIL: gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: in scope now (unexpected
output)

gdb.log shows:

\[{name="L",in_scope="true",type_changed="false",has_more="0"}\][
]+[(]gdb[)]
[ ]*)
-var-update L
^done,changelist=[]
(gdb)
FAIL: gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: in scope now (unexpected
output)

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23378

Pedro Alves <palves at redhat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |8.2

[sergiodj at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23378

Sergio Durigan Junior <sergiodj at redhat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |sergiodj at redhat dot com

--- Comment #1 from Sergio Durigan Junior <sergiodj at redhat dot com> ---
A git bisect tells that the failure was introduced by:

commit c12a5089640109567e2e06f0c5d2d1bf4fb3f5eb (HEAD, refs/bisect/bad)
Author: Stan Cox <***@redhat.com>
Date: Mon Jun 4 10:20:49 2018 -0400

Add client_state struct.

[brobecker at gnat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23378

Joel Brobecker <brobecker at gnat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |brobecker at gnat dot com
Assignee|unassigned at sourceware dot org |scox at redhat dot com

--- Comment #2 from Joel Brobecker <brobecker at gnat dot com> ---
Assigning to Stan, based on the results of the bisection. Stan, would you mind
taking a look, please? This is blocking the GDB 8.2 release.

Thank you!

[brobecker at gnat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23378

--- Comment #3 from Joel Brobecker <brobecker at gnat dot com> ---
Looks like this was fixed by the following commit:

commit 4e2aa472847923f94b99f138d7fc4c77796f8239
Author: Simon Marchi <***@ericsson.com>
Date: Wed Aug 22 13:37:05 2018 -0400

Restore behavior of disabling address randomization by default on GDBserver

Commit

c12a508 ("Add client_state struct.")

inadvertently changed the default behavior of GDBserver wrt address
randomization. The old disable_randomization global variable was
initialized to 1, whereas the corresponding field in the client_state
structure is initialized to 0.

This fixes

make check TESTS="gdb.base/jit-simple.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"
make check TESTS="gdb.base/execl-update-breakpoints.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"

Note that the execl-update-breakpoints.exp would only fail on systems
where the toolchain emits position-independent executables by default
(otherwise the main executable position is never randomized, so the
value of disable_randomization didn't matter).

gdb/gdbserver/ChangeLog:

PR gdb/23374
PR gdb/23375
* server.h (struct client_state) <disable_randomization>:
Initialize to 1.


Not closing just yet, as I believe we want this commit in the gdb-8.2-branch,
and it looks to me like it is not in yet.

[brobecker at gnat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23378

Joel Brobecker <brobecker at gnat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #4 from Joel Brobecker <brobecker at gnat dot com> ---
I pushed the commit to gdb-8.2-branch, so now closing this one.