[Bug build/23917] New: gdb-8.2 fails build on sparc: sparc-linux-nat.c:39:3: error: expected unqualified-id before ‘{’ token

[slyfox at inbox dot ru]

https://sourceware.org/bugzilla/show_bug.cgi?id=23917

Bug ID: 23917
Summary: gdb-8.2 fails build on sparc: sparc-linux-nat.c:39:3:
error: expected unqualified-id before ‘{’ token
Product: gdb
Version: 8.2
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: build
Assignee: unassigned at sourceware dot org
Reporter: slyfox at inbox dot ru
Target Milestone: ---

Created attachment 11412
--> https://sourceware.org/bugzilla/attachment.cgi?id=11412&action=edit
gdb-8.2-sparc-fix-syntax.patch

Originally reported by Rolf Eike Beer at https://bugs.gentoo.org/671726

Seems to be a minor syntax error. This is enough to fix:

--- a/gdb/sparc-linux-nat.c
+++ b/gdb/sparc-linux-nat.c
@@ -36,5 +36,5 @@ public:
{ sparc_fetch_inferior_registers (regcache, regnum); }

- void store_registers (struct regcache *regcache, int regnum) override;
+ void store_registers (struct regcache *regcache, int regnum) override
{ sparc_store_inferior_registers (regcache, regnum); }
};

[slyfox at inbox dot ru]

https://sourceware.org/bugzilla/show_bug.cgi?id=23917

Sergei Trofimovich <slyfox at inbox dot ru> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target| |sparc-*-linux

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23917

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ed2df75c51551cf9b44f7d94179849565ab5bdda

commit ed2df75c51551cf9b44f7d94179849565ab5bdda
Author: Simon Marchi <***@ericsson.com>
Date: Mon Nov 26 14:35:03 2018 -0500

Fix spurious semicolon in sparc-linux-nat.c

Remove a semicolon that should not be there, as reported in PR 23917:

CXX sparc-linux-nat.o
/home/emaisin/src/binutils-gdb/gdb/sparc-linux-nat.c:39:3: error: expected
unqualified-id before ‘{’ token
{ sparc_store_inferior_registers (regcache, regnum); }
^

Tested by rebuilding the file manually (make sparc-linux-nat.o) in a
sparc64-linux-gnu build.

gdb/ChangeLog:

PR gdb/23917
* sparc-linux-nat.c (sparc_linux_nat_target): Remove extraneous
semicolon.

[simon.marchi at ericsson dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23917

Simon Marchi <simon.marchi at ericsson dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |simon.marchi at ericsson dot com
Resolution|--- |FIXED

--- Comment #2 from Simon Marchi <simon.marchi at ericsson dot com> ---
Thanks, fixed by the above.