[Bug gdb/23374] New: [8.1 -> 8.2 regression] gdb.base/execl-update-breakpoints.exp, with --target_board=native-gdbserver

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23374

Bug ID: 23374
Summary: [8.1 -> 8.2 regression]
gdb.base/execl-update-breakpoints.exp, with
--target_board=native-gdbserver
Product: gdb
Version: unknown
Status: NEW
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: palves at redhat dot com
Target Milestone: ---

Comparing 8.1 vs 8.2/master test results on Fedora 27, with
--target_board=native-gdbserver, I see this regression:

-PASS: gdb.base/execl-update-breakpoints.exp: always-inserted off: continue
across exec
+FAIL: gdb.base/execl-update-breakpoints.exp: always-inserted off: continue
across exec
-PASS: gdb.base/execl-update-breakpoints.exp: always-inserted on: continue
across exec
+FAIL: gdb.base/execl-update-breakpoints.exp: always-inserted on: continue
across exec

gdb.log shows:

(gdb) PASS: gdb.base/execl-update-breakpoints.exp: always-inserted off: break
some_function
continue
Continuing.
process 4153 is executing new program:
build/gdb/testsuite/outputs/gdb.base/execl-update-breakpoints/execl-update-breakpoints2
Reading
build/gdb/testsuite/outputs/gdb.base/execl-update-breakpoints/execl-update-breakpoints2
from remote target...
Reading
build/gdb/testsuite/outputs/gdb.base/execl-update-breakpoints/execl-update-breakpoints2
from remote target...
Reading /lib64/ld-linux-x86-64.so.2 from remote target...
Reading /lib64/ld-linux-x86-64.so.2 from remote target...
Reading /lib64/libm.so.6 from remote target...
Reading /lib64/libc.so.6 from remote target...
warning: Could not load shared library symbols for linux-vdso.so.1.
Do you need "set solib-search-path" or "set sysroot"?

Breakpoint 1, main (argc=1, argv=0x7fffab295ad8) at
src/gdb/testsuite/gdb.base/execl-update-breakpoints.c:34
34 len = strlen (argv[0]);
(gdb) FAIL: gdb.base/execl-update-breakpoints.exp: always-inserted off:
continue across exec


Both --target_board=native-extended-gdbserver and native testing pass cleanly.

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23374

Pedro Alves <palves at redhat dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |8.2

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23374

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4e2aa472847923f94b99f138d7fc4c77796f8239

commit 4e2aa472847923f94b99f138d7fc4c77796f8239
Author: Simon Marchi <***@ericsson.com>
Date: Wed Aug 22 13:37:05 2018 -0400

Restore behavior of disabling address randomization by default on GDBserver

Commit

c12a508 ("Add client_state struct.")

inadvertently changed the default behavior of GDBserver wrt address
randomization. The old disable_randomization global variable was
initialized to 1, whereas the corresponding field in the client_state
structure is initialized to 0.

This fixes

make check TESTS="gdb.base/jit-simple.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"
make check TESTS="gdb.base/execl-update-breakpoints.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"

Note that the execl-update-breakpoints.exp would only fail on systems
where the toolchain emits position-independent executables by default
(otherwise the main executable position is never randomized, so the
value of disable_randomization didn't matter).

gdb/gdbserver/ChangeLog:

PR gdb/23374
PR gdb/23375
* server.h (struct client_state) <disable_randomization>:
Initialize to 1.

[simon.marchi at ericsson dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23374

Simon Marchi <simon.marchi at ericsson dot com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |simon.marchi at ericsson dot com
Resolution|--- |FIXED

--- Comment #2 from Simon Marchi <simon.marchi at ericsson dot com> ---
Fixed by commit mentioned above.

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23374

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-8.2-branch branch has been updated by Joel Brobecker
<***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=83b6e2e989510db105c52a02c490ab2c284b5469

commit 83b6e2e989510db105c52a02c490ab2c284b5469
Author: Simon Marchi <***@ericsson.com>
Date: Sun Aug 26 11:46:45 2018 +0200

Restore behavior of disabling address randomization by default on GDBserver

Commit

c12a508 ("Add client_state struct.")

inadvertently changed the default behavior of GDBserver wrt address
randomization. The old disable_randomization global variable was
initialized to 1, whereas the corresponding field in the client_state
structure is initialized to 0.

This fixes

make check TESTS="gdb.base/jit-simple.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"
make check TESTS="gdb.base/execl-update-breakpoints.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"

Note that the execl-update-breakpoints.exp would only fail on systems
where the toolchain emits position-independent executables by default
(otherwise the main executable position is never randomized, so the
value of disable_randomization didn't matter).

gdb/gdbserver/ChangeLog:

PR gdb/23374
PR gdb/23375
* server.h (struct client_state) <disable_randomization>:
Initialize to 1.