[Bug gdb/23097] New: Test case gdb.base/shreloc.exp fails

[rajendra.sy at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23097

Bug ID: 23097
Summary: Test case gdb.base/shreloc.exp fails
Product: gdb
Version: HEAD
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: rajendra.sy at gmail dot com
Target Milestone: ---

Created attachment 10969
--> https://sourceware.org/bugzilla/attachment.cgi?id=10969&action=edit
Patch fixes shell command in shreloc.exp

The shell command on GDB failed with message "Illegal variable name"

test failed
FAIL: gdb.base/shreloc.exp: (msymbol) relocated static vars have different
addresses
FAIL: gdb.base/shreloc.exp: (msymbol) relocated extern vars have different
addresses
FAIL: gdb.base/shreloc.exp: (msymbol) relocated functions have different
addresses

Log:
shell grep -E " static_var_[12]([ ^G]+.*)?$"
/b/syrajendra/debuggers/gdb-sourceware/build/gdb/testsuite/outputs/gdb.base/shreloc/shreloc.txt
Illegal variable name.

shell grep -E " extern_var_[12]([ ^G]+.*)?$"
/b/syrajendra/debuggers/gdb-sourceware/build/gdb/testsuite/outputs/gdb.base/shreloc/shreloc.txt
Illegal variable
name.

shell grep -E " fn_[12]([ ^G]+.*)?$"
/b/syrajendra/debuggers/gdb-sourceware/build/gdb/testsuite/outputs/gdb.base/shreloc/shreloc.txt
Illegal
variable name.

By replacing double quotes with single quotes the error gets fixes.
Attached patch fix this.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23097

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
It seems weird to use "shell" at all, when one can easily read a file
from Tcl.

Anyway - the gdb project doesn't normally review patches in bugzilla.
Please see https://sourceware.org/gdb/wiki/ContributionChecklist
instead.

Thanks!

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23097

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I guess the point of "shell" is so that the command runs on the remote
when doing remote-host testing. So ignore that part :-)