[Bug gdb/23093] New: Missing implementation of "gdbarch_gdb_signal_to/from_target" on FreeBSD

[rajendra.sy at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23093

Bug ID: 23093
Summary: Missing implementation of
"gdbarch_gdb_signal_to/from_target" on FreeBSD
Product: gdb
Version: HEAD
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: rajendra.sy at gmail dot com
Target Milestone: ---

The test case "gdb.base/exitsignal.exp" fails on FreeBSD.

GDB internal variable $_exitsignal is not updated on FreeBSD because of missing
gdb_signal_from_target() & gdb_signal_to_target() functions.

Test log:
Running
/b/syrajendra/debuggers/gdb-sourceware/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/exitsignal.exp
...
FAIL: gdb.base/exitsignal.exp: $_exitsignal is 11 (SIGSEGV) after SIGSEGV.
FAIL: gdb.base/exitsignal.exp: $_exitsignal is 11 (SIGSEGV) after restarting
the inferior

=== gdb Summary ===

# of expected passes 12
# of unexpected failures 2
/b/syrajendra/debuggers/gdb-sourceware/build/gdb/gdb version
8.1.50.20180420-git -nw -nx -data-directory
/b/syrajendra/debuggers/gdb-sourceware/build/gdb/testsuite/../data-directory

[rajendra.sy at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23093

--- Comment #1 from Rajendra S Y <rajendra.sy at gmail dot com> ---
Created attachment 10964
--> https://sourceware.org/bugzilla/attachment.cgi?id=10964&action=edit
Implementation of "gdbarch_gdb_signal_to/from_target" on FreeBSD

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23093

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
Thanks for the patch.
Please follow the contribution instructions to have it reviewed:
https://sourceware.org/gdb/wiki/ContributionChecklist

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23093

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by John Baldwin <***@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e61667ef1413b9fba1bb9dc78744329f8215de74

commit e61667ef1413b9fba1bb9dc78744329f8215de74
Author: Rajendra SY <***@gmail.com>
Date: Thu Nov 29 13:26:31 2018 -0800

Implement the "gdb_signal_to/from_target" gdbarch methods for FreeBSD.

This fixes failures in the gdb.base/exitsignal.exp test.

gdb/ChangeLog:

PR gdb/23093
* gdb/fbsd-tdep.c (fbsd_gdb_signal_from_target)
(fbsd_gdb_signal_to_target): New.
(fbsd_init_abi): Install gdbarch "signal_from_target" and
"signal_to_target" methods.