[Bug build/20658] New: enable -Wimplicit-fallthrough

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20658

Bug ID: 20658
Summary: enable -Wimplicit-fallthrough
Product: gdb
Version: unknown
Status: NEW
Severity: normal
Priority: P2
Component: build
Assignee: unassigned at sourceware dot org
Reporter: tromey at sourceware dot org
Target Milestone: ---

It would be worthwhile to enable the new gcc option -Wimplicit-fallthrough.
This can detect real bugs (I found a few small ones when trying this out).
See also bug 20613 and http://www.viva64.com/en/b/0430/

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20658

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks| |20613


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=20613
[Bug 20613] GDB - a tough nut to crack: only a few bugs found by PVS-Studio

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20658

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
See https://sourceware.org/ml/gdb-patches/2016-09/msg00374.html
But note that this doesn't enable the warning, as there are still
build failures. Next time I update this branch I'll try to remember
to list the remaining failures here.

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=20658

Tom Tromey <tromey at sourceware dot org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I have a longer series now to clean up the warnings.
I'll post it soon.